Skip to content

[#3] Fix more clippy warnings for Rust 1.98 - #1932

Merged
elBoberido merged 2 commits into
eclipse-iceoryx:mainfrom
ekxide:iox2-3-more-clippy-fixes-for-rust-1.98
Aug 20, 2026
Merged

[#3] Fix more clippy warnings for Rust 1.98#1932
elBoberido merged 2 commits into
eclipse-iceoryx:mainfrom
ekxide:iox2-3-more-clippy-fixes-for-rust-1.98

Conversation

@elBoberido

@elBoberido elBoberido commented Aug 20, 2026

Copy link
Copy Markdown
Member

Notes for Reviewer

This time triggered on macOS and Windows.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • [~] Tests follow the best practice for testing
  • [~] Changelog updated in the unreleased section including API breaking changes

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Relates to #3

@elBoberido
elBoberido requested a review from dkroenke August 20, 2026 17:16
@elBoberido
elBoberido force-pushed the iox2-3-more-clippy-fixes-for-rust-1.98 branch 2 times, most recently from 35d2c9b to ebb4296 Compare August 20, 2026 17:23
@elBoberido
elBoberido force-pushed the iox2-3-more-clippy-fixes-for-rust-1.98 branch from ebb4296 to b9a46eb Compare August 20, 2026 17:25
@codecov

codecov Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.33%. Comparing base (5609a00) to head (b9a46eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   76.36%   76.33%   -0.03%     
==========================================
  Files         457      457              
  Lines       46069    46068       -1     
  Branches     1489     1489              
==========================================
- Hits        35179    35165      -14     
- Misses       9628     9641      +13     
  Partials     1262     1262
Flag Coverage Δ
CPP 62.61% <ø> (ø)
Rust 76.18% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/posix/src/process_state.rs 71.96% <100.00%> (-0.06%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido
elBoberido merged commit f9a876e into eclipse-iceoryx:main Aug 20, 2026
65 checks passed
@elBoberido
elBoberido deleted the iox2-3-more-clippy-fixes-for-rust-1.98 branch August 20, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkroenke dkroenke dkroenke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elBoberido @dkroenke